Transition Technology: Ticket #241: 'Preview' button only saving - no 'preview'

ed — Mon, 14 Mar 2011 12:43:32 GMT

In EVENTS it *does* preview, however, and include a captcha (ref: Fi email 09/03/11).

Need the same process across all adding of comments...

priority changed

ed — Fri, 17 Jun 2011 10:54:34 GMT

priority changed from minor to critical

So: ensure all posting process is the same across all bits where they can add stuff. If possible without going too far off the drupal path, remove 'preview' bit, or have 'publish' and 'preview' options next to eachother.

owner, status changed

jim — Fri, 17 Jun 2011 17:07:04 GMT

owner changed from jim to ed
status changed from new to assigned

Drupal can either have previews as optional or as mandatory on NODES. On comments it's a per-CT basis.

Save and Preview are side by side where I've looked.

Can you be a bit more specific please Ed: Is the bug (saving on preview) still happening? Or is there another issue?

If you could provide links/directions to examples that would be great.

owner changed

ed — Mon, 20 Jun 2011 10:54:25 GMT

owner changed from ed to jim

Thanks - yes more detail was required - here it is:

On all CTs in all spaces it's the same - there is only a 'preview' button, which saves and publishes the comment. Please replace with a 'Save' button which publishes. List of tested items with links below...

MAIN SITE:

News item: shows only 'preview': http://www.transitionnetwork.org/comment/reply/17226#comment-form Which publishes the comment (now deleted)

Forums: shows only preview to reply to whole thread (ie not replying to a reply): http://www.transitionnetwork.org/forums/process/web-and-comms/setting-website Which publishes the comment (now deleted)

Forums: shows only preview to reply to a reply: http://www.transitionnetwork.org/comment/reply/12945/749 Which publishes the comment (now delted)

Blogs: shows only preview to reply to a blog post: http://www.transitionnetwork.org/blogs/steph-bradley/2011-06/tale-how-doing-being-came-work-together#comment-13434 Which publishes the comment (now deleted)

Events: http://www.transitionnetwork.org/events/2011-06-24/quaker-and-transition-conference-weekend-quakers-involved-local-transition-initiat#comment-13435 Same as above

CMS:

News: same as above: http://www.transitionnetwork.org/cms/reconomy-project-workspace/news/2011-03-22/community-bakery-starting-rise#comment-13436

Events: same as above: http://www.transitionnetwork.org/cms/reconomy-project-workspace/events/2011-03-21/wwf-values-and-frames-workshop

WORKSPACES:

News: same as above: http://workspaces.transitionnetwork.org/ws/transition-together-community-workspace/news/2011-04-21/transition-together-how-has-it-been-going

Events: same as above: http://workspaces.transitionnetwork.org/comment/reply/40#comment-form

owner changed

jim — Mon, 20 Jun 2011 11:26:08 GMT

owner changed from jim to ed

Yes these are all comment forms.

And as such are configurable by each content type - can be that Preview is required or optional.

Do you want me to make it optional for all CTs? Part of me thinks forcing a preview on Forum posts might help to keep the signal:noise ratio up...

owner changed

ed — Mon, 20 Jun 2011 11:38:16 GMT

owner changed from ed to jim

Make the preview optional. S:N ratio fine atm. The problem is it says 'Preview' when in fact it saves.

So what exactly will we see if Preview is optional? And can I do this?

priority changed

jim — Mon, 20 Jun 2011 12:48:34 GMT

priority changed from critical to major

OK, all CTs now allow optional previews so there's a save and preview button side by side.

FYI Ed, these settings (as most other CT-specific stuff) is in 'Content management' -> 'Content types' -> 'Edit XXX', then in the Comments expandable section. Many delights lay therein, m'lud.

However 'Preview' still bloody saves. And it appears the 'Comment Upload' module (used to attach files to comments for resources/patterns is doing it - disabled the module and the problem went away....

Will trawl through https://drupal.org/project/issues/comment_upload?text=Preview&status=All&priorities=All&categories=All&version=All&component=All and find a fix.

Downgrading...

status changed; resolution set

jim — Wed, 22 Jun 2011 22:23:24 GMT

status changed from assigned to closed
resolution set to fixed

Couldn't see anything in the issue list that would fix it, or anything obvious in the code.

But then I remembered the Comment Upload module was only used so that people could attach stuff to comments on patterns.

So I've disabled it for now, problem solved.