Changes between Version 25 and Version 27 of Ticket #590


Ignore:
Timestamp:
09/08/13 17:08:55 (3 years ago)
Author:
jim
Comment:

13.. More on block caching: It now works!

I needed to apply a core block module patch that comes with blockcache_alter -- this tells the block system to ignore that some modules are using hook_node_grants(). I've now done some checks and can confirm this is faster...

Futher, the Context module also interferes, and indeed uses its own version of the block load/render code I patched from core... So I patched this similarly and block caching has started to work.

According to Devel, without caching the homepage makes ~10 calls to block_block that each takes 0.22-0.75ms to generate, or about 3ms over 10 queries. With caching they all take are gone, saving queries and calls. This should be a nice little boost to the site.

So that means I and F are now done and working, summary updated.

NOTE we now need to keep an eye out for any caching oddness, though I'd expect this for blocks in the CMS only really.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #590

    • Property Add Hours to Ticket changed from 1.15 to 1.75
    • Property Total Hours changed from 8.85 to 10.7

  • Ticket #590 – Description

    v25 v27  
    1414 
    1515=== New, to run past Ed === 
    16 '''I) Re-enable block caching.''' -- 2-6 hours, high risk, high reward -- Per comment 24, a module (probably Content Access) is stopping Drupal caching blocks, which for some of them means a fair amount of pointless overhead. We need to somehow get around this and get blocks cached if possible. R&D mainly, perhaps with some hacking/patching - but I'd stop short of doing this if so. 
    17  
    1816'''J) Convert inline PHP into module code and features''' -- various parts (2-3 hours for block code; 4-8 hours to make Features be used across site), high reward, low risk -- {{{Eval()}}}uated code is much slower than PHP in files... We have a few blocks and many views that are loaded from the database and evaluated. Ideally the blocks would be moved to the 'Transition Extras' module, and the views would be pushed into features. This work is good to do for maintainability and D7 upgrades, too. 
    1917 
    … …  
    2624'''D) Review Views caching''' ~~1-2 hours, low risk, high reward -- this was done a while back but I think -- done (task 12) in comment 21.~~ 
    2725 
    28 '''F) Force blocks caches to cached appropriately (and be rendered/included only as needed) -- NEEDS I) to complete!'' ''' ~~-- 1-2 hours, medium reward, low risk -- BOA packages the [https://drupal.org/project/blockcache_alter Block Cache Alter], which makes sure Drupal only renders blocks when needed. Potential small but nice boost quickly in whole site. -- per comment 22, block caching is disabled by other modules so this will have to go on hold for now.~~ 
     26'''F) Force blocks caches to cached appropriately (and be rendered/included only as needed)''' ~~1-2 hours, medium reward, low risk -- BOA packages the [https://drupal.org/project/blockcache_alter Block Cache Alter], which makes sure Drupal only renders blocks when needed. Potential small but nice boost quickly in whole site. -- per comment 22, block caching is disabled by other modules so this will have to go on hold for now.~~ 
    2927 
    3028'''H) Remove CustomError module all together''' ~~1/2 hour, low risk, low reward -- We should take out the PHP code from the 403 section of CustomError and put it into a simple page entry. See comment 6 below as this has happened for 404s (which need no PHP). We can then remove the CustomError module all together, saving lots of sessions. I would go ahead and do this but since the 403 page has various displays depending on user type, I wanted to raise it here as it *may* have side effects. Or not...~~ 
    3129 
     30'''I) Re-enable block caching.''' ~~2-6 hours, high risk, high reward -- Per comment 24, a module (probably Content Access) is stopping Drupal caching blocks, which for some of them means a fair amount of pointless overhead. We need to somehow get around this and get blocks cached if possible. R&D mainly, perhaps with some hacking/patching - but I'd stop short of doing this if so.~~ 
    3231 
    3332=== On hold for now ===