Transition Technology: Ticket #608: User profile pictures are too big

priority, description changed

ed — Mon, 14 Oct 2013 08:38:25 GMT

priority changed from major to minor
description modified (diff)

hours, totalhours changed

jim — Mon, 14 Oct 2013 18:19:41 GMT

hours changed from 0.0 to 0.05
totalhours changed from 0.0 to 0.05

FWIW, this CSS will make any 'too big' image in the content area fit the available space nicely:

#main-content img {
  max-width: 100%;
  height: auto;
}

ed — Tue, 15 Oct 2013 07:56:19 GMT

if it is that quick can you roll it out jim? (sorry ben!)

hours, totalhours changed

jim — Wed, 16 Oct 2013 19:30:23 GMT

hours changed from 0.0 to 0.1
totalhours changed from 0.05 to 0.15

I've just committed the change to the scss, but not yet compiled to CSS or pushed to the server.

Ed, Ben, do you want me to do that? I'd prefer this was tested first really since it will affect EVERY image in the content area -- though if they're less than the width available nothing should happen.

Let me know.

hours, totalhours changed

jim — Thu, 17 Oct 2013 16:25:00 GMT

hours changed from 0.0 to 0.5
totalhours changed from 0.15 to 0.65

FYI I've now recompiled the SASS on my machine from the latest changes... It wouldn' compile and there is a lot of broken scss fragments. I've therefore removed the 'v1' and v2' scss files as they're not being used.

After a cleanup it now compiles. I've also set Compass to be in Production mode so it doesn't output all those comments and debugging. Ben, please remember to pull before you do anything else.

This will arrive in STG for us to have a look at soon.

ed — Tue, 22 Oct 2013 13:17:02 GMT

Great - let me know when to check on STG please

ed — Wed, 06 Nov 2013 16:35:10 GMT

I'm looking on STG. I'm also having a brainwave (rather late one) and have removed the Transition Nearby block from the 'people/*' pages - which now makes the profile pics look fine.

So my initial bug is fixed by removing the block from the people pages.

*Ahem*

I can't see any examples of pictures looking too big or too small now - SO

I approve this...

hours, status, totalhours changed; resolution set

jim — Mon, 18 Nov 2013 12:19:56 GMT

hours changed from 0.0 to 0.15
status changed from new to closed
resolution set to fixed
totalhours changed from 0.65 to 0.8

This fix is also on PROD, and tested by going to https://www.transitionnetwork.org/people/tina-clarke and then setting page width narrower... image gracefully scaled rather than overlapping.

Marking fixed.

ed — Wed, 20 Nov 2013 15:54:21 GMT