Transition Technology: Ticket #638: Question about notifications option for content creators

benj — Thu, 28 Nov 2013 13:20:09 GMT

Hi Jim There's a patch here that addresses this issue by changing the default status of the checkbox "Do not send notifications for this update" that appears at the bottom of nodes meaning that only those who really intend to send out notifications for updates will tick it: https://drupal.org/node/752664

Is it cool to apply it?

Alternatively Ed I could more simply just turn of the ability to send out notifications on updates for these content types, so only notifications are sent on node creation... https://www.transitionnetwork.org/admin/messaging/notifications/events

hours, totalhours changed

benj — Thu, 28 Nov 2013 13:20:21 GMT

hours changed from 0.0 to 0.33
totalhours changed from 0.0 to 0.33

ed — Thu, 28 Nov 2013 13:29:54 GMT

Ben - we need ot keep the node update option as people create the nodes, then tinker with them, then send notificiations...

benj — Thu, 28 Nov 2013 13:35:18 GMT

Ok.. then we'll need to apply the patch to get this functionality... I'll await Jims answer as I'm not sure about wether applying this patch is 'ok'.... it's quite an old patch, and whenever the notification module gets updated again it would need to be re-applied...

hours, totalhours changed

jim — Thu, 28 Nov 2013 13:53:22 GMT

hours changed from 0.0 to 0.15
totalhours changed from 0.33 to 0.48

Making the change is no problem, but that patch is too 'dumb' in its handling, per comment #23 on that issue.

But it's Ed's shout - we either:

Make all updates go out by default (current situation) and people will need to remember to check box to not send out minor edits,
Or the opposite -- nothing goes out unless they explicitly change it - this is Ben's proposal.

Or we do something else, which means we need another patch, to send 'create node' notifications out always, but make 'update node' notifications opt-in. I'm yet to see a patch do that.

Any patch applied will need to be available and added to the the makefile, too.

Thoughts?

ed — Thu, 28 Nov 2013 15:59:23 GMT

My desire is to go for:

Nothing goes out unless the content creator (of a blog, or rob's blog, or social reporter, or news item) explicitly changes it to send a notification.

jim — Thu, 28 Nov 2013 16:47:10 GMT

Including when content created? No updates for new content?

If that's the case it's all good and Ben should apply the patch and update the makefile.

ed — Thu, 28 Nov 2013 17:45:01 GMT

oh god i've got a terrible deja-vu meets sitting on a merry-go-round feeling about this thread; i'm feeling a bit sick. we've been here before haven't we? sorry.

I'm going to go puke in a bucket. back to this on monday.

benj — Thu, 28 Nov 2013 17:59:04 GMT

I could apply the patch and update the makefile, but I think I understand that Ed's having second thoughts....

I guess the 'Other' thing to do would be to script a new patch, or write a new module, that does it, but is this needed enough to warrant the coding time (it's not something I could do either...).

ed — Thu, 28 Nov 2013 18:04:12 GMT

it's an icky decision that I've been at before and it's done my head in, so let's leave for now and I'll revisit after being with Rob in Totnes.

Focus on #633 :)

owner, status changed

benj — Mon, 02 Dec 2013 12:12:30 GMT

owner changed from benj to ed
status changed from new to assigned