Ticket #170 (closed enhancement: duplicate)
Enable login as a pop-up on one page
| Reported by: | ed | Owned by: | jim |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | Drupal modules & settings | Keywords: | |
| Cc: | Estimated Number of Hours: | 0.0 | |
| Add Hours to Ticket: | 0 | Billable?: | yes |
| Total Hours: | 1.3 |
Description
Users want to be able to log in while staying on the page they are on. Currently users are directed to /login and then re-directed back to the page they logged in from. Jim added fancy login module to enable this but it clashed with logintoboggan, so put in some php to redirect users as above.
Establish custom code required to make fancylogin and logintobbagan to work together properly, seeing if the developers approve. If they do, press on.
Change History
comment:2 Changed 6 years ago by ed
- Milestone set to Phase 3
this remains a 250 stand alone bounty mate - you'll make a lot of friends with this one...
comment:3 Changed 6 years ago by jim
- Status changed from new to closed
- Resolution set to fixed
I just realised that Lightbox2 (already in place to show images nicely) allows the login box to be made into a nice popup on ALL pages...
It needs a bit of a CSS/JS tweak, but it's in - let me know!!!!!!!!!
Don't like doing myself out of a bounty, but Fancy Login is therefore redundant if we are happy with this route.
comment:4 Changed 6 years ago by jim
- Add Hours to Ticket changed from 0.0 to 0.3
- Total Hours changed from 0.0 to 0.3
comment:5 Changed 6 years ago by jim
- Status changed from closed to reopened
- Resolution fixed deleted
Actually there's a problem that the popup is blank on LIVE - works on my machine... Hmmm will attend to.
comment:6 Changed 6 years ago by ed
press on, it's worth it. there will always be plenty of other things for bounties.
comment:7 Changed 6 years ago by laura
Lightbox2 should work well rather than the icky Fancy Login module -keep at it! Do need to check that will degrade if users haven't got js enabled (and on some mobile browsers too, ie take them to the original login page if the popups don't work) ...
Another way (which used for a test on another site but it did need a tweakage to perfect and some styling too) is similar to the Lightbox one which can be found at - http://www.luckyspin.org/?p=130 (Ajax login which also degrades without js too - see the link in the article with a site where it's running on)
L
comment:8 Changed 6 years ago by jim
It definitely degrades - adds a jquery event handler to lightbox enabled links, so no JS, normal /user/login applies.
Can also do the site contact form in the same way.
But it's broken on LIVE... Probably an SSL thing, will look into it on my next pass.
comment:9 Changed 6 years ago by jim
- Add Hours to Ticket changed from 0.0 to 1.0
- Total Hours changed from 0.3 to 1.3
Hmmm..... The change between SSL and not is the cause of the pain here - we're breaking into the security dogma of http://en.wikipedia.org/wiki/Same_origin_policy - in other words we're asking for a secure page/script from an insecure page, which is bad from a security POV and therefore blocked.
I think Laura's method might also be affected too, I quickly scanned the code but don't have time to check fully now.
Fancy Login DOES work though, it's designed to handle SSL.
Will try once more with a clear head, otherwise we're back to fixing Fancy Login instead...
comment:12 Changed 5 years ago by ed
will this in some way be related to #262
comment:13 Changed 5 years ago by jim
- Status changed from reopened to closed
- Resolution set to duplicate
We're going to need to look again and the SSO stuff for this and #262 and PSE -- new ticket to be added as part of PSE infrastructure research.
Popup not great idea any more since we're using SSL.
Closing this one
laura says this can be handled in a block without extra module action - for discussions