Ticket #345 (closed defect: worksforme)

Opened 5 years ago

Last modified 5 years ago

TRAC time 'add hours' not working

Reported by: jim Owned by: chris
Priority: critical Milestone: Phase 5
Component: Trac Keywords:
Cc: ed Estimated Number of Hours: 0.2
Add Hours to Ticket: 0 Billable?: yes
Total Hours: 1.44

Description

When you put something in "Add Hours to Ticket", it overwrites the "Total hours" with that value, rather than adding...

Change History

comment:1 Changed 5 years ago by chris

  • Status changed from new to accepted

I have confirmed this, will look into it tomorrow

comment:2 Changed 5 years ago by chris

  • Estimated Number of Hours changed from 0 to 0.2

I have upgraded to the latest version of this plugin, see wiki:TimingAndEstimationPlugin for install notes

 cd ~/timingandestimationplugin/trac0.11
 svn up
 python setup.py bdist_egg
 sudo cp dist/timingandestimationplugin-0.9.8-py2.6.egg /web/tech.transitionnetwork.org/trac/plugins/

comment:3 Changed 5 years ago by chris

  • Add Hours to Ticket changed from 0.0 to 0.1
  • Total Hours changed from 0.0 to 0.1

Testing adding time...

comment:4 Changed 5 years ago by chris

  • Add Hours to Ticket changed from 0.0 to 0.4
  • Total Hours changed from 0.1 to 0.5

I have opened a ticket about this here ​https://trac-hacks.org/ticket/9196

comment:5 Changed 5 years ago by chris

  • Add Hours to Ticket changed from 0.0 to 0.03
  • Total Hours changed from 0.5 to 0.53

Testing

comment:6 Changed 5 years ago by chris

  • Add Hours to Ticket changed from 0.0 to 0.1
  • Total Hours changed from 0.53 to 0.63

Hmm it all seems to be working now :-)

comment:7 Changed 5 years ago by chris

What is somewhat confusing is that the position of the timer has moved.

comment:8 Changed 5 years ago by chris

  • Add Hours to Ticket changed from 0.0 to 0.1
  • Status changed from accepted to closed
  • Resolution set to fixed
  • Total Hours changed from 0.63 to 0.73

So this is working OK now, closing ticket.

comment:9 Changed 5 years ago by chris

  • Cc ed added
  • Add Hours to Ticket changed from 0.0 to 0.3
  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Total Hours changed from 0.73 to 1.03

OK, so there is a problem here after all.

It looks like the totalhours field didn't exist before and the total time was kept in the hours field and now when time is added to an existing ticket it does wipe out previous hours, so these need adding back, but adding them back will change when they were done and also in the case of several people booking hours to a ticket the hours will need adding back by each person.

There shouldn't be a problem for new tickets or for times after the first new comment to a ticket.

I'm looking at things at a database level and at the tickets for this plugin: ​https://trac-hacks.org/query?status=closed&component=TimingAndEstimationPlugin&order=priority

comment:10 Changed 5 years ago by chris

  • Add Hours to Ticket changed from 0.0 to 0.41
  • Total Hours changed from 1.03 to 1.44

I don't think my comments above are right, something odd was happening but it seems OK now - I couldn't find any references to this problem and it seems to be working OK now...

comment:11 Changed 5 years ago by chris

  • Status changed from reopened to closed
  • Resolution set to worksforme

comment:12 Changed 5 years ago by chris

Perhaps the problems only occurred between the upgrade to squeeze and the upgrade of the timing plugin?

Note: See TracTickets for help on using tickets.