Ticket #349 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

Design enhancement for photos on ingredients items

Reported by: ed Owned by: laura
Priority: critical Milestone: Phase 5
Component: Drupal modules & settings Keywords:
Cc: jim Estimated Number of Hours: 0.0
Add Hours to Ticket: 0 Billable?: yes
Total Hours: 0.05

Description

photos on ingredient items would benefit from being set in a bit tidier.

Would it be possible to end off the coloured header bars with rounded corners rather than running under the picture?
How about a border around the picture?

is this a Laura job (she starts officially next week)

https://www.transitionnetwork.org/ingredients/starting/inclusion-and-diversity

Change History

comment:1 Changed 5 years ago by jim

  • Add Hours to Ticket changed from 0.0 to 0.05
  • Total Hours changed from 0.0 to 0.05

Hmmm... the issue is the image is 'floated' over the content, pushing text aside but not full-width blocks like the headings. And since the fields associated with each heading can be variable length, we'd have to make that a 2 column fixed width affair.

Doable, but not quick and might not look great for all ingredients.

Laura's welcome to have a look, or I could try now, but it's going to need a little care because that's a custom panel pane with another pane overlapping it.

comment:2 Changed 5 years ago by laura

Agree with Jim there - if aiming to have images on all areas like these ones (and consistent width / resizing of images when uploading would probably help too) it may be much more preferable to have 2 fixed columns on this and possibly the text/title area 66% width and the image 33% width of the space available as a ratio of text vs image. (I'll take a look at the type of images that have been uploaded already to get an idea on this) Poss would need a default sample image where areas don't have an image yet too. When done I can easily add a border to the image, probably for this purpose a white padded background of 5px with a clean grey 1px line going round the edge.

comment:3 Changed 5 years ago by ed

AHA ze Vebmaster Vombat has been lured from her tree...

this sounds like a sensible suggestion to me; it will make it look much nicer.

the headings are 'challenge', 'description', 'solution', so a defined width on LHS is do-able...

comment:4 Changed 5 years ago by jim

Fine by me, but worth watching - Laura - that the grey works with every colour in the ingredient palette. And that the plan works with both landscape and portrait images.

Note there are style overrides in the General section of the ingredient panel for this, doing things like floating that image right and padding it properly. You'd want to start there.

comment:5 Changed 5 years ago by laura

Do you mean grey as in the grey padded borders on other site images? If so we can add that easily into the css or use the overrides, will take a gander at this.

comment:6 Changed 5 years ago by ed

  • Owner changed from jim to laura
  • Status changed from new to assigned

comment:7 Changed 5 years ago by jim

  • Cc jim added; laura removed

comment:8 Changed 5 years ago by ed

what's going on with this?

One week to hard deadline.

comment:9 Changed 5 years ago by ed

what's going on with this?

One day to live.

comment:10 Changed 5 years ago by laura

Images with new styling should be visible on the individual ingredients pages...

comment:11 Changed 5 years ago by ed

  • Status changed from assigned to closed
  • Resolution set to fixed

sound. closed.

Note: See TracTickets for help on using tickets.