Ticket #600 (closed maintenance: fixed)

Opened 3 years ago

Last modified 3 years ago

Numbers missing from Initiatives search page

Reported by: ed Owned by: jim
Priority: major Milestone: Maintenance
Component: Unassigned Keywords:
Cc: Estimated Number of Hours: 0.0
Add Hours to Ticket: 0 Billable?: yes
Total Hours: 0.2

Description

When users do a search on /initiatives we are missing a number which pertains to the results of the report:

It should say "XXX initiatives match your search criteria"

The XXX bit is missing

please check and resolve

Change History

comment:1 Changed 3 years ago by jim

  • Add Hours to Ticket changed from 0.0 to 0.15
  • Total Hours changed from 0.0 to 0.15

Looked into this and it's a result of #590 proposal K: Add & enable Views Lite Pager on big views.

The use of this simpler pager saves an expensive database query... But that's need to get the count.

So your choice, Ed:

  1. Reinstate the slow/expensive pager and get the count back
  2. Drop the whole line 'initiatives match your search criteria'
  3. Something else.

comment:2 Changed 3 years ago by ed

Choice is made:

  1. Drop it.

Therefore - I've looked at the view and see this .php - can I remove the whole lot?

<?php
Add results count - using different var names to avoid scoping issues
$my_view = views_get_current_view();
$my_total = $my_view->total_rows;
print '<p><strong>' . t('%count initiatives matched your search criteria.', array('%count' => $my_total) ) .'</strong></p>';
?>

comment:3 Changed 3 years ago by jim

  • Add Hours to Ticket changed from 0.0 to 0.05
  • Total Hours changed from 0.15 to 0.2

In this case you can indeed drop it -- though I've just gone ahead and done it - sorry to steal your PHP thunder!

comment:4 Changed 3 years ago by jim

  • Status changed from new to closed
  • Resolution set to fixed

This is done, so closing.

Note: See TracTickets for help on using tickets.