Ticket #615 (closed task: fixed)

Opened 3 years ago

Last modified 3 years ago

Move to GMap 6.x-2.x-dev as and get clusterer to work

Reported by: jim Owned by: ed
Priority: major Milestone: Maintenance
Component: Drupal modules & settings Keywords:
Cc: ed Estimated Number of Hours: 0.0
Add Hours to Ticket: 0 Billable?: yes
Total Hours: 1.3

Description (last modified by jim) (diff)

This is largely done, but the only tasks left are:

  1. Make a patch and add to our makefile so our custom markers appear ok.
  2. Get the clusterer to work per the comments & issues in comment:1 below.

Per an email I got from Google:

As you may be aware, JavaScript? Maps API v2 was scheduled for shutdown on May 19, 2013. After listening to feedback from developers we decided to extend the deprecation timeline by six months, to November 19, 2013 to allow more time for migration to v3 of the API.

On November 19, 2013 we will deploy a JavaScript? wrapper that attempts to automagically turn remaining v2 maps into v3 maps. Though we expect this wrapper to work for most simple maps, we cannot guarantee that your maps will continue to function. We therefore highly recommend that you migrate to v3 before November 19. The good news is that Google Maps JavaScript? API v3 is more robust and feature rich than v2, and we’ve written a guide to assist the migration.

So this ticket is to do the update to the GMap module, testing and tweaking.

Critical as we only have until 19 November for this...

Change History

comment:1 Changed 3 years ago by jim

  • Add Hours to Ticket changed from 0.0 to 0.1
  • Total Hours changed from 0.0 to 0.1

comment:2 Changed 3 years ago by jim

  • Add Hours to Ticket changed from 0.0 to 0.8
  • Total Hours changed from 0.1 to 0.9

I've also done some checks on stg2 site -- see http://stg2.transitionnetwork.org/projects/pedal-wind-powered-shipping-container-cinema-offgrid-caravanserai-east-london

The mapping and markers works well except for the following:

  1. The cluster does not work, so all markers have to be shown alone on the 'big maps' lest there be none showing. To do with https://drupal.org/node/1459606 and https://drupal.org/node/1573062 and will need some patches applying.
  2. The module is complaining that the TN-specific markers for the mulling/official items on the big ini map are non-existent. They are on this version of GMap, so we need to make a patche that will allow Drush to put them into the right folder when the module is added to a platform.

Will investigate the above further this week, add the patches and get ready to do this in PROD too.

Adding time for reading, R&D and work in STG mucking about with settings.

comment:3 Changed 3 years ago by jim

  • Add Hours to Ticket changed from 0.0 to 0.3
  • Priority changed from critical to major
  • Total Hours changed from 0.9 to 1.2

Since the old API shuts down tomorrow, I've gone ahead and replaced the 1.x custom version of the GMap we were using with the 2.x DEV branch. The caveats above apply, except I've manually copied the markers from our old gmap module.

To do on this ticket:

  1. Make a patch and add to our makefile so our custom markers appear ok.
  2. Get the clusterer to work per the comments/issues above.

Note that this new API will be faster to render lots of markers than before, so the lack clusterer issue will only be a problem on a couple of big maps on old/mobile hardware.

Downgrading from Critical for these reasons. This effectively fixes #622 and #616 too.

Last edited 3 years ago by jim (previous) (diff)

comment:4 Changed 3 years ago by jim

  • Add Hours to Ticket changed from 0.0 to 0.05
  • Total Hours changed from 1.2 to 1.25
  • Description modified (diff)
  • Summary changed from Move to GMap 6.x-2.x-dev as Google Maps API v2 is being shelved to Move to GMap 6.x-2.x-dev as and get clusterer to work

Update ticket summary & title.

comment:5 Changed 3 years ago by jim

  • Status changed from new to closed
  • Resolution set to fixed

Per a chat with Ed, we're not going to be doing anything with this on D6... Clusterer support will be reinstated in D7 if necessary.

Note that hardware, Google js libraries and browsers have got a lot better since we needed to add the clusterer exactly 2 years ago.

Closing.

comment:6 Changed 3 years ago by jim

  • Add Hours to Ticket changed from 0.0 to 0.05
  • Total Hours changed from 1.25 to 1.3

comment:7 Changed 3 years ago by jim

Note the patch for our custom GMap markers is now included in the makefile.

So this is double-closed!

Note: See TracTickets for help on using tickets.